chrome/browser/extensions/extension_bookmarks_module.cc - Issue 274059: Small cleanup to extension function registration to avoid scattered definitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.cc

Issue 274059: Small cleanup to extension function registration to avoid scattered definitions. (Closed)

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_bookmarks_module.cc

diff --git a/chrome/browser/extensions/extension_bookmarks_module.cc b/chrome/browser/extensions/extension_bookmarks_module.cc

index 4bef0f2ccea8ec16f469b179c6175d2dd8ec7307..0724a5a7de69eef7c1dfb6f9ad2974175bb54d5d 100644

--- a/chrome/browser/extensions/extension_bookmarks_module.cc

+++ b/chrome/browser/extensions/extension_bookmarks_module.cc

@@ -360,8 +360,7 @@ bool SearchBookmarksFunction::RunImpl() {

bool RemoveBookmarkFunction::RunImpl() {

bool recursive = false;

- if (name() ==

- extension_bookmarks_module_constants::kRemoveBookmarkTreeFunction)

+ if (name() == RemoveTreeBookmarkFunction::function_name())

recursive = true;

BookmarkModel* model = profile()->GetBookmarkModel();