Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.h

Issue 274059: Small cleanup to extension function registration to avoid scattered definitions. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browser_actions_api.h
diff --git a/chrome/browser/extensions/extension_browser_actions_api.h b/chrome/browser/extensions/extension_browser_actions_api.h
index e08baa425c4a952c46aa438485952cd40cb21890..c5193d692240807a2ee97716a738cab3c9f3b09e 100755
--- a/chrome/browser/extensions/extension_browser_actions_api.h
+++ b/chrome/browser/extensions/extension_browser_actions_api.h
@@ -9,29 +9,23 @@
class BrowserActionSetNameFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setName")
};
class BrowserActionSetIconFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setIcon")
};
class BrowserActionSetBadgeTextFunction : public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeText")
};
class BrowserActionSetBadgeBackgroundColorFunction
: public SyncExtensionFunction {
virtual bool RunImpl();
+ DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setBadgeBackgroundColor")
};
-namespace extension_browser_actions_api_constants {
-
-// Function names.
-extern const char kSetNameFunction[];
-extern const char kSetIconFunction[];
-extern const char kSetBadgeTextFunction[];
-extern const char kSetBadgeBackgroundColorFunction[];
-
-}; // namespace extension_browser_actions_api_constants
-
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSER_ACTIONS_API_H_

Powered by Google App Engine
This is Rietveld 408576698