Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Side by Side Diff: chrome/browser/extensions/extension_toolstrip_api.cc

Issue 274059: Small cleanup to extension function registration to avoid scattered definitions. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_toolstrip_api.h" 5 #include "chrome/browser/extensions/extension_toolstrip_api.h"
6 6
7 #include "base/json_writer.h" 7 #include "base/json_writer.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "chrome/browser/browser.h" 9 #include "chrome/browser/browser.h"
10 #include "chrome/browser/extensions/extension_host.h" 10 #include "chrome/browser/extensions/extension_host.h"
11 #include "chrome/browser/extensions/extension_message_service.h" 11 #include "chrome/browser/extensions/extension_message_service.h"
12 #include "chrome/browser/extensions/extension_shelf_model.h" 12 #include "chrome/browser/extensions/extension_shelf_model.h"
13 #include "chrome/browser/extensions/extension_tabs_module_constants.h" 13 #include "chrome/browser/extensions/extension_tabs_module_constants.h"
14 #include "chrome/browser/profile.h" 14 #include "chrome/browser/profile.h"
15 15
16 namespace extension_toolstrip_api_functions {
17 const char kExpandFunction[] = "toolstrip.expand";
18 const char kCollapseFunction[] = "toolstrip.collapse";
19 }; // namespace extension_toolstrip_api_functions
20
21 namespace extension_toolstrip_api_events { 16 namespace extension_toolstrip_api_events {
22 const char kOnToolstripExpanded[] = "toolstrip.onExpanded.%d"; 17 const char kOnToolstripExpanded[] = "toolstrip.onExpanded.%d";
23 const char kOnToolstripCollapsed[] = "toolstrip.onCollapsed.%d"; 18 const char kOnToolstripCollapsed[] = "toolstrip.onCollapsed.%d";
24 }; // namespace extension_toolstrip_api_events 19 }; // namespace extension_toolstrip_api_events
25 20
26 namespace { 21 namespace {
27 // Errors. 22 // Errors.
28 const char kNotAToolstripError[] = "This page is not a toolstrip."; 23 const char kNotAToolstripError[] = "This page is not a toolstrip.";
29 const char kAlreadyExpandedError[] = "This toolstrip is already expanded."; 24 const char kAlreadyExpandedError[] = "This toolstrip is already expanded.";
30 const char kAlreadyCollapsedError[] = "This toolstrip is already collapsed."; 25 const char kAlreadyCollapsedError[] = "This toolstrip is already collapsed.";
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 void ToolstripEventRouter::OnToolstripCollapsed(Profile* profile, 156 void ToolstripEventRouter::OnToolstripCollapsed(Profile* profile,
162 int routing_id, 157 int routing_id,
163 const GURL &url) { 158 const GURL &url) {
164 ListValue args; 159 ListValue args;
165 DictionaryValue* obj = new DictionaryValue(); 160 DictionaryValue* obj = new DictionaryValue();
166 if (!url.is_empty()) 161 if (!url.is_empty())
167 obj->SetString(keys::kUrlKey, url.spec()); 162 obj->SetString(keys::kUrlKey, url.spec());
168 args.Append(obj); 163 args.Append(obj);
169 DispatchEvent(profile, routing_id, events::kOnToolstripCollapsed, args); 164 DispatchEvent(profile, routing_id, events::kOnToolstripCollapsed, args);
170 } 165 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698