Issue 2121012: Simplify libcrash_dumper interface and make window_manager gen crash dumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2121012: Simplify libcrash_dumper interface and make window_manager gen crash dumps (Closed)

Created:
10 years, 7 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat, sosa

CC:
chromium-os-reviews_chromium.org, Greg Spencer (Chromium), Daniel Erat

Base URL:
ssh://git@chromiumos-git//chromeos

Visibility:
Public.

Description

Simplify libcrash_dumper interface and make window_manager gen crash dumps BUG=1513

Patch Set 1 #

Patch Set 2 : Basic cleanup #

Total comments: 1

Patch Set 3 : Change crash dumper lib name #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -44 lines)			Patch
M	src/platform/crash/Makefile	View	1 2	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/platform/crash/crash_dumper.h	View	1	2 chunks	+8 lines, -10 lines	0 comments	Download
M	src/platform/crash/crash_dumper.cc	View	1	5 chunks	+22 lines, -13 lines	0 comments	Download
M	src/platform/crash/crash_reporter.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/platform/window_manager/SConstruct	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/platform/window_manager/main.cc	View		3 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

10 years, 7 months ago (2010-05-20 21:13:02 UTC) #3

LGTM for the window manager changes (I checked and don't see anything currently
using the --minidump_dir flag, so I think that its removal is safe here). 
Thanks!

http://codereview.chromium.org/2121012/diff/2001/3002
File src/platform/crash/crash_dumper.cc (right):

http://codereview.chromium.org/2121012/diff/2001/3002#newcode36
src/platform/crash/crash_dumper.cc:36: static google_breakpad::ExceptionHandler
*s_breakpad_handler;
nit (that doesn't need to be updated in this change): Chrome style is to put *'s
one space to the left, flush against the type instead of against the variable.

Expand Messages | Collapse Messages