Simplify libcrash_dumper interface and make window_manager gen crash dumps

src/platform/window_manager/main.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <unistd.h>
 
 #include <cmath>
 #include <cstdlib>
 #include <ctime>
 
 extern "C" {
 #include <X11/Xlib.h>
 }
 
 #include <gflags/gflags.h>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
-#ifdef USE_BREAKPAD
-#include "handler/exception_handler.h"
-#endif
 #include "window_manager/callback.h"
 #include "window_manager/compositor.h"
 #include "window_manager/event_loop.h"
 #include "window_manager/real_compositor.h"
 #if defined(COMPOSITOR_OPENGL)
 #include "window_manager/real_gl_interface.h"
 #elif defined(COMPOSITOR_OPENGLES)
 #include "window_manager/gles/real_gles2_interface.h"
 #endif
 #include "window_manager/real_x_connection.h"
 #include "window_manager/util.h"
 #include "window_manager/window_manager.h"
 
 DECLARE_bool(wm_use_compositing);  // from window_manager.cc
 
 DEFINE_string(log_dir, ".",
               "Directory where logs should be written; created if it doesn't "
               "exist.");
 DEFINE_string(display, "",
               "X Display to connect to (overrides DISPLAY env var).");
 DEFINE_bool(logtostderr, false,
             "Write logs to stderr instead of to a file in log_dir.");
-DEFINE_string(minidump_dir, ".",
-              "Directory where crash minidumps should be written; created if "
-              "it doesn't exist.");
 DEFINE_int32(pause_at_start, 0,
              "Specify this to pause for N seconds at startup.");
 DEFINE_bool(logged_in, true, "Whether Chrome is logged in or not.");
 
 using std::string;
 using window_manager::Compositor;
 using window_manager::EventLoop;
 using window_manager::GetTimeAsString;
 using window_manager::MockCompositor;
 using window_manager::RealCompositor;
@@ skipping 33 matching lines @@
 
 int main(int argc, char** argv) {
   google::ParseCommandLineFlags(&argc, &argv, true);
   if (!FLAGS_display.empty())
     setenv("DISPLAY", FLAGS_display.c_str(), 1);
 
   CommandLine::Init(argc, argv);
   if (FLAGS_pause_at_start > 0)
     sleep(FLAGS_pause_at_start);
 
-#ifdef USE_BREAKPAD
-  if (!file_util::CreateDirectory(FilePath(FLAGS_minidump_dir)))
-    LOG(ERROR) << "Unable to create minidump directory " << FLAGS_minidump_dir;
-  google_breakpad::ExceptionHandler exception_handler(
-      FLAGS_minidump_dir, NULL, NULL, NULL, true);
-#endif
-
   const string log_basename = StringPrintf(
       "%s.%s", WindowManager::GetWmName(),
       GetTimeAsString(::time(NULL)).c_str());
   if (!FLAGS_logtostderr) {
     if (!file_util::CreateDirectory(FilePath(FLAGS_log_dir))) {
       LOG(ERROR) << "Unable to create logging directory " << FLAGS_log_dir;
     } else {
       SetUpLogSymlink(StringPrintf("%s/%s.LATEST",
                                    FLAGS_log_dir.c_str(),
                                    WindowManager::GetWmName()),
@@ skipping 55 matching lines @@
   const int x11_fd = xconn.GetConnectionFileDescriptor();
   LOG(INFO) << "X11 connection is on fd " << x11_fd;
   event_loop.AddFileDescriptor(
       x11_fd, NewPermanentCallback(&wm, &WindowManager::ProcessPendingEvents));
   event_loop.AddPrePollCallback(
       NewPermanentCallback(&wm, &WindowManager::ProcessPendingEvents));
 
   event_loop.Run();
   return 0;
 }