Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: src/platform/crash/Makefile

Issue 2121012: Simplify libcrash_dumper interface and make window_manager gen crash dumps (Closed) Base URL: ssh://git@chromiumos-git//chromeos
Patch Set: Change crash dumper lib name Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/platform/crash/crash_dumper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/crash/Makefile
diff --git a/src/platform/crash/Makefile b/src/platform/crash/Makefile
index 06679f91297a53e81cb81e6ee59c4566582697c1..0d818b4254a15563120a6247c7c4cd4501efac03 100644
--- a/src/platform/crash/Makefile
+++ b/src/platform/crash/Makefile
@@ -3,7 +3,7 @@
# found in the LICENSE file.
CRASH_BIN = crash_reporter
-CRASH_LIB = libcrash_dumper.so
+CRASH_LIB = libcrash.so
CRASH_OBJS = system_logging.o user_collector.o
TEST_OBJS = $(CRASH_OBJS) system_logging_mock.o
TEST_BINS = user_collector_test
@@ -17,14 +17,15 @@ LIB_DIRS =
# We need -fPIC for linking objects into shared objects.
CXXFLAGS += -fPIC -Wall -Werror
-all: $(CRASH_BIN) $(CRASH_LIB)
-
-$(CRASH_BIN): crash_reporter.o $(CRASH_OBJS)
- $(CXX) $(CXXFLAGS) $(LIB_DIRS) $^ $(LIBS) -o $@
+all:
+ echo "Specify either $(CRASH_BIN) or $(CRASH_LIB)"
$(CRASH_LIB): crash_dumper.o
$(CXX) -shared -lbreakpad_client $^ -o $@
+$(CRASH_BIN): crash_reporter.o $(CRASH_OBJS)
+ $(CXX) $(CXXFLAGS) $(LIB_DIRS) $^ -lcrash_dumper $(LIBS) -o $@
+
tests: $(TEST_BINS)
user_collector_test: user_collector_test.o $(TEST_OBJS)
« no previous file with comments | « no previous file | src/platform/crash/crash_dumper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698