Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: src/platform/window_manager/main.cc

Issue 2121012: Simplify libcrash_dumper interface and make window_manager gen crash dumps (Closed) Base URL: ssh://git@chromiumos-git//chromeos
Patch Set: Change crash dumper lib name Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform/window_manager/SConstruct ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/window_manager/main.cc
diff --git a/src/platform/window_manager/main.cc b/src/platform/window_manager/main.cc
index e2c74f8f1c7f311f5c684bcc3dc70169f1264c37..d0d983ffd76aae84626e16749bf0bf49d084b650 100644
--- a/src/platform/window_manager/main.cc
+++ b/src/platform/window_manager/main.cc
@@ -20,9 +20,6 @@ extern "C" {
#include "base/logging.h"
#include "base/scoped_ptr.h"
#include "base/string_util.h"
-#ifdef USE_BREAKPAD
-#include "handler/exception_handler.h"
-#endif
#include "window_manager/callback.h"
#include "window_manager/compositor.h"
#include "window_manager/event_loop.h"
@@ -45,9 +42,6 @@ DEFINE_string(display, "",
"X Display to connect to (overrides DISPLAY env var).");
DEFINE_bool(logtostderr, false,
"Write logs to stderr instead of to a file in log_dir.");
-DEFINE_string(minidump_dir, ".",
- "Directory where crash minidumps should be written; created if "
- "it doesn't exist.");
DEFINE_int32(pause_at_start, 0,
"Specify this to pause for N seconds at startup.");
DEFINE_bool(logged_in, true, "Whether Chrome is logged in or not.");
@@ -101,13 +95,6 @@ int main(int argc, char** argv) {
if (FLAGS_pause_at_start > 0)
sleep(FLAGS_pause_at_start);
-#ifdef USE_BREAKPAD
- if (!file_util::CreateDirectory(FilePath(FLAGS_minidump_dir)))
- LOG(ERROR) << "Unable to create minidump directory " << FLAGS_minidump_dir;
- google_breakpad::ExceptionHandler exception_handler(
- FLAGS_minidump_dir, NULL, NULL, NULL, true);
-#endif
-
const string log_basename = StringPrintf(
"%s.%s", WindowManager::GetWmName(),
GetTimeAsString(::time(NULL)).c_str());
« no previous file with comments | « src/platform/window_manager/SConstruct ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698