Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: src/platform/window_manager/SConstruct

Issue 2121012: Simplify libcrash_dumper interface and make window_manager gen crash dumps (Closed) Base URL: ssh://git@chromiumos-git//chromeos
Patch Set: Change crash dumper lib name Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform/crash/crash_reporter.cc ('k') | src/platform/window_manager/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/window_manager/SConstruct
diff --git a/src/platform/window_manager/SConstruct b/src/platform/window_manager/SConstruct
index 908678cdc07ffe33e75d7f09aea831cc8635f6bd..3db3b51794812055a006602952fb0775e488c3e1 100644
--- a/src/platform/window_manager/SConstruct
+++ b/src/platform/window_manager/SConstruct
@@ -176,16 +176,17 @@ srcs = Split('''\
libtest = wm_env.Library('test', Split(srcs))
wm_env.Prepend(LIBS=[libwm_core, libwm_ipc])
-if 'USE_BREAKPAD' in ARGUMENTS:
- wm_env.Append(CPPDEFINES=['USE_BREAKPAD'], LIBS=['libbreakpad'])
backend_defines = {'opengl': ['COMPOSITOR_OPENGL'],
'opengles': ['COMPOSITOR_OPENGLES']}
wm_env.Append(CPPDEFINES=backend_defines[backend])
+# Do not include crash dumper in the unit test environment
+test_env = wm_env.Clone()
+wm_env.Append(LIBS=['libcrash'])
+
wm_env.Program('wm', 'main.cc')
-test_env = wm_env.Clone()
test_env.Append(LIBS=['gtest'])
# libtest needs to be listed first since it depends on wm_core and wm_ipc.
test_env.Prepend(LIBS=[libtest])
« no previous file with comments | « src/platform/crash/crash_reporter.cc ('k') | src/platform/window_manager/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698