Move hunspell dictionaris out of "third_party/hunspell"....

Move hunspell dictionaris out of "third_party/hunspell".
This change just moves the all hunspell dictionaries (which are used only for unit tests) from "third_party/hunspell" to "third_party/hunspell_dictionaries" to reduce the size of the Chromium source tarball.

BUG=44543
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48011

[Hironori Bono, 2010-05-19 09:54:21]

Greetings Evan,

This change does not seems to include some files ("bg_BG.dic", "hu-HU.aff",
"hu-HU.dic", and "ro-RO-2-0.bdic") because they are too large to be uploaded to
Rietveld. (I think they will be moved to "third_party/hunspell_dictionaries" as
well when landing this change.)
Thank you for your review in advance.

Regards,

Hironori Bono

[Hironori Bono, 2010-05-19 10:55:16]

(Added brettw as a reviewer to hear his opinions.)

[brettw, 2010-05-19 15:43:50]

LGTM. Can you change the README.chromium in the hunspell directory to give the
location of the dictionary files?

[Evan Stade, 2010-05-19 20:56:03]

is there a gyp rule somewhere that copies these to the out directory, or how do
the tests know where to look?

[Hironori Bono, 2010-05-20 01:54:37]

On 2010/05/19 15:43:50, brettw wrote:
> LGTM. Can you change the README.chromium in the hunspell directory to give the
> location of the dictionary files?

Thank you for noticing this. I have updated "hunspell/README.chromium" and
"hunspell_dictionaries/README.chromium" to apply your comments.

Regards,

Hironori Bono

[Hironori Bono, 2010-05-20 01:57:57]

Greetings,

On 2010/05/19 20:56:03, Evan Stade wrote:
> is there a gyp rule somewhere that copies these to the out directory, or how
do
> the tests know where to look?

Thank you for your comment. Out unit tests find their dictionaries from a
hard-coded directory ("third_party/hunspell/dictionaries") as listed in the
following code snippet. So, we need to change this code when we merge this
change into the Chromium tree.

  FilePath GetHunspellDirectory() {
    FilePath hunspell_directory;
    if (!PathService::Get(base::DIR_SOURCE_ROOT, &hunspell_directory))
      return FilePath();

    hunspell_directory = hunspell_directory.AppendASCII("third_party");
    hunspell_directory = hunspell_directory.AppendASCII("hunspell");
    hunspell_directory = hunspell_directory.AppendASCII("dictionaries");
    return hunspell_directory;
  }

Regards,

Hironori Bono

[Evan Stade, 2010-05-20 18:15:07]

ahh, now I get it. Hunspell is already in DEPS but now it will have two entries
in DEPS (one for the dictionaries)? Great, LGTM!