Don't allow updating tabs to javascript URLs without host

Don't allow updating tabs to javascript URLs without host
permissions to that tab.

Cleaned up a few things along the way:

- added a GetExtension() method to 
  ExtensionFunctionDispatcher and ExtensionFunction since it 
  was used in more than one place.

- Removed first param from chrome.test.failCallback() since 
  it wasn't used anywhere.

- Added a convenience CanAccessHost() method to Extension,
  since it seems likely to be commonly used.

- Refactored setup of mock host resolver in browsertest, 
  since the way it was, you could only customize it at the 
  testsuite level, not the test level.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25971

[Aaron Boodman, 2009-09-10 08:48:00]

I still need to follow up on the TODO in extension_tabs_module.cc. I will do
that tomorrow.

[Erik does not do reviews, 2009-09-10 18:23:21]

http://codereview.chromium.org/199074/diff/1022/1032
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/199074/diff/1022/1032#newcode985
Line 985: // The path component is not used for host permissions, so we force it
to
I guess this means we can wind up with multiple duplicate entries in
host_permissions_.  Not that big of a deal, but it might be worth cleaning that
up.

http://codereview.chromium.org/199074/diff/1022/1034
File chrome/common/extensions/url_pattern.h (right):

http://codereview.chromium.org/199074/diff/1022/1034#newcode103
Line 103: path_escaped_ = "";
Is this just unimplemented?

[Aaron Boodman, 2009-09-10 18:55:31]

http://codereview.chromium.org/199074/diff/1022/1032
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/199074/diff/1022/1032#newcode985
Line 985: // The path component is not used for host permissions, so we force it
to
On 2009/09/10 18:23:21, Erik Kay wrote:
> I guess this means we can wind up with multiple duplicate entries in
> host_permissions_.  Not that big of a deal, but it might be worth cleaning
that
> up.

Actually the permissions are kept in a vector now, so there can already be
dupes. I will probably change it to a set at some point but it doesn't really
matter for anything right now.

http://codereview.chromium.org/199074/diff/1022/1034
File chrome/common/extensions/url_pattern.h (right):

http://codereview.chromium.org/199074/diff/1022/1034#newcode103
Line 103: path_escaped_ = "";
On 2009/09/10 18:23:21, Erik Kay wrote:
> Is this just unimplemented?

I'm resetting it because the escaped form is computed and cached lazily the
first time it is used.

[Erik does not do reviews, 2009-09-10 18:58:25]

LGTM

On Thu, Sep 10, 2009 at 11:55 AM,  <aa@chromium.org> wrote:
>
> http://codereview.chromium.org/199074/diff/1022/1032
> File chrome/common/extensions/extension.cc (right):
>
> http://codereview.chromium.org/199074/diff/1022/1032#newcode985
> Line 985: // The path component is not used for host permissions, so we
> force it to
> On 2009/09/10 18:23:21, Erik Kay wrote:
>>
>> I guess this means we can wind up with multiple duplicate entries in
>> host_permissions_. =A0Not that big of a deal, but it might be worth
>
> cleaning that
>>
>> up.
>
> Actually the permissions are kept in a vector now, so there can already
> be dupes. I will probably change it to a set at some point but it
> doesn't really matter for anything right now.
>
> http://codereview.chromium.org/199074/diff/1022/1034
> File chrome/common/extensions/url_pattern.h (right):
>
> http://codereview.chromium.org/199074/diff/1022/1034#newcode103
> Line 103: path_escaped_ =3D "";
> On 2009/09/10 18:23:21, Erik Kay wrote:
>>
>> Is this just unimplemented?
>
> I'm resetting it because the escaped form is computed and cached lazily
> the first time it is used.
>
> http://codereview.chromium.org/199074
>