Don't allow updating tabs to javascript URLs without host

chrome/test/in_process_browser_test.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_
 #define CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_
 
+#include "net/base/mock_host_resolver.h"
 #include "net/url_request/url_request_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class Browser;
 class Profile;
 namespace net {
 class RuleBasedHostResolverProc;
 }
 
 // Base class for tests wanting to bring up a browser in the unit test process.
@@ skipping 45 matching lines @@
   // Override this rather than TestBody.
   virtual void RunTestOnMainThread() = 0;
 
   // Override this to add command line flags specific to your test.
   virtual void SetUpCommandLine(CommandLine* command_line) {}
 
   // Override this to add any custom cleanup code that needs to be done on the
   // main thread before the browser is torn down.
   virtual void CleanUpOnMainThread() {}
 
-  // Allows subclasses to configure the host resolver procedure. By default
-  // this blocks requests to google.com as Chrome pings that on startup and we
-  // don't want to do that during testing.
-  virtual void ConfigureHostResolverProc(net::RuleBasedHostResolverProc* proc);
-
   // Invoked when a test is not finishing in a timely manner.
   void TimedOut();
 
   // Sets Initial Timeout value.
   void SetInitialTimeoutInMS(int initial_timeout);
 
   // Starts an HTTP server.
   HTTPTestServer* StartHTTPServer();
 
   // Creates a browser with a single tab (about:blank), waits for the tab to
   // finish loading and shows the browser.
   //
   // This is invoked from Setup.
   virtual Browser* CreateBrowser(Profile* profile);
 
+  // Returns the host resolver being used for the tests. Subclasses might want
+  // to configure it inside tests.
+  net::RuleBasedHostResolverProc* host_resolver() {
+    return host_resolver_.get();
+  }
+
   // Sets some test states (see below for comments).  Call this in your test
   // constructor.
   void set_show_window(bool show) { show_window_ = show; }
   void EnableDOMAutomation() { dom_automation_enabled_ = true; }
   void EnableSingleProcess() { single_process_ = true; }
 
  private:
   // Invokes CreateBrowser to create a browser, then RunTestOnMainThread, and
   // destroys the browser.
   void RunTestOnMainThreadLoop();
@@ skipping 18 matching lines @@
   // We muck with the global command line for this process.  Keep the original
   // so we can reset it when we're done.
   scoped_ptr<CommandLine> original_command_line_;
 
   // Saved to restore the value of RenderProcessHost::run_renderer_in_process.
   bool original_single_process_;
 
   // Initial timeout value in ms.
   int initial_timeout_;
 
+  // Host resolver to use during the test.
+  scoped_refptr<net::RuleBasedHostResolverProc> host_resolver_;
+
   DISALLOW_COPY_AND_ASSIGN(InProcessBrowserTest);
 };
 
 // We only want to use IN_PROC_BROWSER_TEST in binaries which will properly
 // isolate each test case. Otherwise hard-to-debug, possibly intermittent
 // crashes caused by carrying state in singletons are very likely.
 #if defined(ALLOW_IN_PROC_BROWSER_TEST)
 
 #define IN_PROC_BROWSER_TEST_(test_case_name, test_name, parent_class,\
                               parent_id)\
@@ skipping 20 matching lines @@
             GTEST_TEST_CLASS_NAME_(test_case_name, test_name)>);\
 void GTEST_TEST_CLASS_NAME_(test_case_name, test_name)::RunTestOnMainThread()
 
 #define IN_PROC_BROWSER_TEST_F(test_fixture, test_name)\
   IN_PROC_BROWSER_TEST_(test_fixture, test_name, test_fixture,\
                     ::testing::internal::GetTypeId<test_fixture>())
 
 #endif  // defined(ALLOW_IN_PROC_BROWSER_TEST)
 
 #endif  // CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_