Don't allow updating tabs to javascript URLs without host

chrome/common/extensions/extension.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "app/resource_bundle.h"
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 964 matching lines @@
       }
 
       // Only accept http/https persmissions at the moment.
       if ((pattern.scheme() != chrome::kHttpScheme) &&
           (pattern.scheme() != chrome::kHttpsScheme)) {
         *error = ExtensionErrorUtils::FormatErrorMessage(
             errors::kInvalidPermissionScheme, IntToString(i));
         return false;
       }
 
+      // The path component is not used for host permissions, so we force it to

[Erik does not do reviews, 2009/09/10 18:23:21]

I guess this means we can wind up with multiple duplicate entries in
host_permissions_.  Not that big of a deal, but it might be worth cleaning that
up.

[Aaron Boodman, 2009/09/10 18:55:31]

Actually the permissions are kept in a vector now, so there can already be
dupes. I will probably change it to a set at some point but it doesn't really
matter for anything right now.

+      // match all paths.
+      pattern.set_path("/*");
+
       host_permissions_.push_back(pattern);
     }
   }
 
   // Initialize default locale (if present).
   if (source.HasKey(keys::kDefaultLocale)) {
     std::string default_locale;
     if (!source.GetString(keys::kDefaultLocale, &default_locale)) {
       *error = errors::kInvalidDefaultLocale;
       return false;
@@ skipping 85 matching lines @@
 }
 
 FilePath Extension::GetIconPath(Icons icon) {
   std::map<int, std::string>::const_iterator iter =
       icons_.find(Extension::EXTENSION_ICON_LARGE);
   if (iter == icons_.end())
     return FilePath();
   return GetResourcePath(iter->second);
 }
 
+bool Extension::CanAccessHost(const GURL& url) const {
+  for (HostPermissions::const_iterator host = host_permissions_.begin();
+       host != host_permissions_.end(); ++host) {
+    if (host->MatchesUrl(url))
+      return true;
+  }
+
+  return false;
+}
+
 const std::set<std::string> Extension::GetEffectiveHostPermissions() const {
   std::set<std::string> effective_hosts;
 
   for (HostPermissions::const_iterator host = host_permissions_.begin();
        host != host_permissions_.end(); ++host)
     effective_hosts.insert(host->host());
 
   for (UserScriptList::const_iterator content_script = content_scripts_.begin();
        content_script != content_scripts_.end(); ++content_script) {
     UserScript::PatternList::const_iterator pattern =
@@ skipping 17 matching lines @@
     UserScript::PatternList::const_iterator pattern =
         content_script->url_patterns().begin();
     for (; pattern != content_script->url_patterns().end(); ++pattern) {
       if (pattern->match_subdomains() && pattern->host().empty())
         return true;
     }
   }
 
   return false;
 }