Don't allow updating tabs to javascript URLs without host

chrome/common/extensions/url_pattern.h

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_
 #define CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_
 
 #include <string>
 
 #include "googleurl/src/gurl.h"
 
@@ skipping 80 matching lines @@
   // Gets the host the pattern matches. This can be an empty string if the
   // pattern matches all hosts (the input was <scheme>://*/<whatever>).
   std::string host() const { return host_; }
 
   // Gets whether to match subdomains of host().
   bool match_subdomains() const { return match_subdomains_; }
 
   // Gets the path the pattern matches with the leading slash. This can have
   // embedded asterisks which are interpreted using glob rules.
   std::string path() const { return path_; }
+  void set_path(const std::string& path) {
+    path_ = path;
+    path_escaped_ = "";

[Erik does not do reviews, 2009/09/10 18:23:21]

Is this just unimplemented?

[Aaron Boodman, 2009/09/10 18:55:31]

I'm resetting it because the escaped form is computed and cached lazily the
first time it is used.

+  }
 
  private:
   // Returns true if |test| matches our host.
   bool MatchesHost(const GURL& test) const;
 
   // Returns true if |test| matches our path.
   bool MatchesPath(const GURL& test) const;
 
   // The scheme for the pattern.
   std::string scheme_;
 
   // The host without any leading "*" components.
   std::string host_;
 
   // Whether we should match subdomains of the host. This is true if the first
   // component of the pattern's host was "*".
   bool match_subdomains_;
 
   // The path to match. This is everything after the host of the URL, or
   // everything after the scheme in the case of file:// URLs.
   std::string path_;
 
   // The path with "?" and "\" characters escaped for use with the
   // MatchPattern() function. This is populated lazily, the first time it is
   // needed.
   mutable std::string path_escaped_;
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_