Build sync engine as part of the browser build

Build sync engine as part of the browser build.

As before, syncapi is built as a dynamic library, and only
on windows.  The difference is that it's built from source,
rather than being pulled in as a binary.

Changes to sync engine code:
 * Use OS_WIN instead of OS_WINDOWS (requires build_config.h).

 * Rename platform-specific files to match the chrome convention.
   This allows them to be excluded by rules that already exist
   in chrome.gyp.  The convention is either a /win/ directory,
   or an _win.cc at the end of the file.  Other valid platforms
   are _mac, _linux, and _posix

Changes to DEPS:
 * On Windows, pull in pthreads-win32.

Changes to chrome.gyp:
 * Add new library targets for sync, notifier, sync_proto, and
   syncapi.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26295

[idana, 2009-09-15 00:16:15]

LGTM assuming the win trybot passes.

Also, it'd be nice if chron can take a look at the gyp stuff.

[chron_chromium.org, 2009-09-15 17:07:56]

LGTM otherwise

http://codereview.chromium.org/193103/diff/2001/2013
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/193103/diff/2001/2013#newcode62
Line 62: #endif  // OS_WIN || OS_WIN
// OS_WIN

[ncarter (slow), 2009-09-15 18:01:05]

http://codereview.chromium.org/193103/diff/2001/2013
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/193103/diff/2001/2013#newcode62
Line 62: #endif  // OS_WIN || OS_WIN
On 2009/09/15 17:07:56, chron_chromium.org wrote:
> // OS_WIN

Fixed, thanks.

http://codereview.chromium.org/193103/diff/2001/2064
File chrome/chrome.gyp (right):

http://codereview.chromium.org/193103/diff/2001/2064#newcode6265
Line 6265: '<(SHARED_INTERMEDIATE_DIR)/chrome/browser/sync/protocol/sync.pb.h',
This should be <(protoc_out_dir)

[Zachary Kuznia, 2009-09-15 18:43:48]

LGTM