Issue 155022: Fix few trivial Coverity issues, mainly PASS_BY_VALUE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155022: Fix few trivial Coverity issues, mainly PASS_BY_VALUE. (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix few trivial Coverity issues, mainly PASS_BY_VALUE. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19974

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
M	base/directory_watcher_unittest.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	base/file_path.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/simple_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/tracked_objects.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/tracked_objects.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/x509_certificate.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

I started looking at Coverity. This patch is very trivial, just to get started. Please ...

11 years, 5 months ago (2009-07-02 22:54:51 UTC) #1

huanr

11 years, 5 months ago (2009-07-02 23:02:19 UTC) #2

LGTM. For PASS_BY_VALUE issues, you can mark the defects as 
Classification = False, Action = Fix. Basically this means False positive and
the code is correct. However we can make suitable change to remove the defect.

Expand Messages | Collapse Messages