Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: base/tracked_objects.h

Issue 155022: Fix few trivial Coverity issues, mainly PASS_BY_VALUE. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/simple_thread.h ('k') | base/tracked_objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/tracked_objects.h
diff --git a/base/tracked_objects.h b/base/tracked_objects.h
index f355b8dd9262446b659755d7f11fb02ffb2f7f2e..1934afba47b90a1e9a18e6ed133c9cccc533f06c 100644
--- a/base/tracked_objects.h
+++ b/base/tracked_objects.h
@@ -255,7 +255,7 @@ class Comparator {
// A comparator can be refined by specifying what to do if the selected basis
// for comparison is insufficient to establish an ordering. This call adds
// the indicated attribute as the new "least significant" basis of comparison.
- void SetTiebreaker(Selector selector, const std::string required);
+ void SetTiebreaker(Selector selector, const std::string& required);
// Indicate if this instance is set up to sort by the given Selector, thereby
// putting that information in the SortGrouping, so it is not needed in each
@@ -268,10 +268,10 @@ class Comparator {
void SetSubgroupTiebreaker(Selector selector);
// Translate a keyword and restriction in URL path to a selector for sorting.
- void ParseKeyphrase(const std::string key_phrase);
+ void ParseKeyphrase(const std::string& key_phrase);
// Parse a query in an about:objects URL to decide on sort ordering.
- bool ParseQuery(const std::string query);
+ bool ParseQuery(const std::string& query);
// Output a header line that can be used to indicated what items will be
// collected in the group. It lists all (potentially) tested attributes and
« no previous file with comments | « base/simple_thread.h ('k') | base/tracked_objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698