base/file_path.cc - Issue 155022: Fix few trivial Coverity issues, mainly PASS_BY_VALUE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_path.cc

Issue 155022: Fix few trivial Coverity issues, mainly PASS_BY_VALUE. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/file_path.cc

diff --git a/base/file_path.cc b/base/file_path.cc

index f3420543108e25bd731108c563e31c16eac4a447..fa93b2a679b6f133d61b3556ecb8bf0eefc70f6a 100644

--- a/base/file_path.cc

+++ b/base/file_path.cc

@@ -83,7 +83,7 @@ bool IsPathAbsolute(const FilePath::StringType& path) {

#endif // FILE_PATH_USES_DRIVE_LETTERS

}

-bool AreAllSeparators(FilePath::StringType input) {

+bool AreAllSeparators(const FilePath::StringType& input) {

for (FilePath::StringType::const_iterator it = input.begin();

it != input.end(); ++it) {

if (!FilePath::IsSeparator(*it))

« no previous file with comments | « base/directory_watcher_unittest.cc ('k') | base/simple_thread.h » ('j') | no next file with comments »