Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2122)

Unified Diff: net/base/x509_certificate.h

Issue 155022: Fix few trivial Coverity issues, mainly PASS_BY_VALUE. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/tracked_objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate.h
diff --git a/net/base/x509_certificate.h b/net/base/x509_certificate.h
index 5956826aef572cd0b83bf910b56c7480e6587c74..1e2419e24e72ad4926a0be21c7244f2daf22e8b2 100644
--- a/net/base/x509_certificate.h
+++ b/net/base/x509_certificate.h
@@ -75,7 +75,7 @@ class X509Certificate : public base::RefCountedThreadSafe<X509Certificate> {
// Principal represent an X.509 principal.
struct Principal {
Principal() { }
- explicit Principal(std::string name) : common_name(name) { }
+ explicit Principal(const std::string& name) : common_name(name) { }
// The different attributes for a principal. They may be "".
// Note that some of them can have several values.
« no previous file with comments | « base/tracked_objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698