Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 11357: Move the platform files form port to skia for Mac only. Hopefully this won't ... (Closed)

Created:
12 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move the platform files form port to skia for Mac only. Hopefully this won't affect other platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5845

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -853 lines) Patch
M base/gfx/bitmap_platform_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/platform_canvas_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/platform_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/SConscript View 1 chunk +5 lines, -0 lines 0 comments Download
A + skia/ext/bitmap_platform_device_mac.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + skia/ext/bitmap_platform_device_mac.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + skia/ext/platform_canvas_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + skia/ext/platform_canvas_mac.cc View 1 chunk +2 lines, -4 lines 0 comments Download
A + skia/ext/platform_device_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + skia/ext/platform_device_mac.cc View 1 chunk +1 line, -3 lines 0 comments Download
M skia/skia.xcodeproj/project.pbxproj View 8 chunks +32 lines, -0 lines 4 comments Download
M webkit/SConscript.port View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/port/platform/graphics/skia/public/BitmapPlatformDevice.h View 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceMac.h View 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceMac.cpp View 1 chunk +0 lines, -291 lines 0 comments Download
M webkit/port/platform/graphics/skia/public/PlatformCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformCanvasMac.h View 1 chunk +0 lines, -88 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformCanvasMac.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M webkit/port/platform/graphics/skia/public/PlatformDevice.h View 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformDeviceMac.h View 1 chunk +0 lines, -86 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformDeviceMac.cpp View 1 chunk +0 lines, -163 lines 0 comments Download
M webkit/webkit.xcodeproj/project.pbxproj View 5 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
12 years, 1 month ago (2008-11-21 19:39:47 UTC) #1
brettw
12 years, 1 month ago (2008-11-21 20:13:33 UTC) #2
Mark Mentovai
OK, LGTM http://codereview.chromium.org/11357/diff/221/33 File skia/skia.xcodeproj/project.pbxproj (right): http://codereview.chromium.org/11357/diff/221/33#newcode504 Line 504: A70A3BA70ED7385100C31871 /* ext */, ext should ...
12 years, 1 month ago (2008-11-21 20:19:20 UTC) #3
Amanda Walker
12 years, 1 month ago (2008-11-21 20:33:03 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698