Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10553042: sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler (Closed)

Created:
8 years, 6 months ago by tim (not reviewing)
Modified:
8 years, 6 months ago
Reviewers:
Nicolas Zea, akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow)
Visibility:
Public.

Description

sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler The net effect of this patch is that a few lingering callsites of OnUnrecoverableError (resulting in full sync shutdown) from within data type specific code are changed over to OnSingleDatatypeUnrecoverableError. Removes need to post task to ProfileSyncService from FrontendDataTypeController, which is the only legit use for making ProfileSyncService SupportsWeakPtr (which will be removed in a later patch). zea FYI BUG=132017, 100829 TEST=unit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142836

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -125 lines) Patch
M chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/data_type_error_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/data_type_error_handler_mock.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/fake_data_type_controller.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/fake_data_type_controller.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller.h View 1 chunk +0 lines, -2 lines 1 comment Download
M chrome/browser/sync/glue/ui_data_type_controller.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tim (not reviewing)
8 years, 6 months ago (2012-06-18 18:42:27 UTC) #1
akalin
On 2012/06/18 18:42:27, timsteele wrote: LGTM Clarify in CL description that removing supportsweakptr will be ...
8 years, 6 months ago (2012-06-18 21:35:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10553042/9001
8 years, 6 months ago (2012-06-18 21:44:06 UTC) #3
akalin
oops, forgot one comment http://codereview.chromium.org/10553042/diff/9001/chrome/browser/sync/glue/ui_data_type_controller.h File chrome/browser/sync/glue/ui_data_type_controller.h (left): http://codereview.chromium.org/10553042/diff/9001/chrome/browser/sync/glue/ui_data_type_controller.h#oldcode49 chrome/browser/sync/glue/ui_data_type_controller.h:49: // UnrecoverableErrorHandler interface. UEH -> ...
8 years, 6 months ago (2012-06-18 21:49:03 UTC) #4
tim (not reviewing)
8 years, 6 months ago (2012-06-18 22:11:47 UTC) #5 
On 2012/06/18 21:49:03, akalin wrote:
> oops, forgot one comment
> 
>
http://codereview.chromium.org/10553042/diff/9001/chrome/browser/sync/glue/ui...
> File chrome/browser/sync/glue/ui_data_type_controller.h (left):
> 
>
http://codereview.chromium.org/10553042/diff/9001/chrome/browser/sync/glue/ui...
> chrome/browser/sync/glue/ui_data_type_controller.h:49: //
> UnrecoverableErrorHandler interface.
> UEH -> DataTypeErrorHandler

Ah, fixed in http://codereview.chromium.org/10559050/ along with other renames
(and I didn't want to reset the CQ !)

Powered by Google App Engine
This is Rietveld 408576698