chrome/browser/sync/glue/fake_data_type_controller.cc - Issue 10553042: sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/fake_data_type_controller.cc

Issue 10553042: sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/fake_data_type_controller.h ('k') | chrome/browser/sync/glue/frontend_data_type_controller.h » ('j') | chrome/browser/sync/glue/ui_data_type_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/fake_data_type_controller.cc

diff --git a/chrome/browser/sync/glue/fake_data_type_controller.cc b/chrome/browser/sync/glue/fake_data_type_controller.cc

index 1f837a299d8cbbb2b892fba67e63c48cef2a0ac4..20f64a24094cde959a263c072e2199236ba309d0 100644

--- a/chrome/browser/sync/glue/fake_data_type_controller.cc

+++ b/chrome/browser/sync/glue/fake_data_type_controller.cc

@@ -99,12 +99,6 @@ DataTypeController::State FakeDataTypeController::state() const {

return state_;

}

-void FakeDataTypeController::OnUnrecoverableError(

- const tracked_objects::Location& from_here,

- const std::string& message) {

- ADD_FAILURE() << message;

void FakeDataTypeController::OnSingleDatatypeUnrecoverableError(

const tracked_objects::Location& from_here,

const std::string& message) {

@@ -127,4 +121,3 @@ void FakeDataTypeController::SimulateModelLoadFinishing() {

}

} // namespace browser_sync