Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7616)

Unified Diff: chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc

Issue 10553042: sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc b/chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc
index cae10c107618c0a09e763110f31d851c5a7f4987..7ad09640cc2aa927883bff009f202a3a570486ef 100644
--- a/chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc
@@ -465,12 +465,13 @@ TEST_F(SyncNewNonFrontendDataTypeControllerTest, StopStart) {
EXPECT_EQ(DataTypeController::RUNNING, new_non_frontend_dtc_->state());
}
-TEST_F(SyncNewNonFrontendDataTypeControllerTest, OnUnrecoverableError) {
+TEST_F(SyncNewNonFrontendDataTypeControllerTest,
+ OnSingleDatatypeUnrecoverableError) {
SetStartExpectations();
SetAssociateExpectations();
SetActivateExpectations(DataTypeController::OK);
EXPECT_CALL(*dtc_mock_, RecordUnrecoverableError(_, "Test"));
- EXPECT_CALL(service_, OnUnrecoverableError(_,_)).WillOnce(
+ EXPECT_CALL(service_, OnDisableDatatype(_,_,_)).WillOnce(
InvokeWithoutArgs(new_non_frontend_dtc_.get(),
&NewNonFrontendDataTypeController::Stop));
SetStopExpectations();
@@ -479,12 +480,12 @@ TEST_F(SyncNewNonFrontendDataTypeControllerTest, OnUnrecoverableError) {
WaitForDTC();
EXPECT_EQ(DataTypeController::RUNNING, new_non_frontend_dtc_->state());
// This should cause new_non_frontend_dtc_->Stop() to be called.
- BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
- base::Bind(
- &NewNonFrontendDataTypeControllerFake::OnUnrecoverableError,
- new_non_frontend_dtc_.get(),
- FROM_HERE,
- std::string("Test")));
+ BrowserThread::PostTask(BrowserThread::DB, FROM_HERE, base::Bind(
+ &NewNonFrontendDataTypeControllerFake::
+ OnSingleDatatypeUnrecoverableError,
+ new_non_frontend_dtc_.get(),
+ FROM_HERE,
+ std::string("Test")));
WaitForDTC();
EXPECT_EQ(DataTypeController::NOT_RUNNING, new_non_frontend_dtc_->state());
}
@@ -492,4 +493,3 @@ TEST_F(SyncNewNonFrontendDataTypeControllerTest, OnUnrecoverableError) {
} // namespace
} // namespace browser_sync
-

Powered by Google App Engine
This is Rietveld 408576698