Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2748)

Unified Diff: chrome/browser/sync/glue/non_frontend_data_type_controller.cc

Issue 10553042: sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/non_frontend_data_type_controller.cc
diff --git a/chrome/browser/sync/glue/non_frontend_data_type_controller.cc b/chrome/browser/sync/glue/non_frontend_data_type_controller.cc
index ee9da809df5f1e050a5881abef1e10f3be075e85..7fda4235e7c687ba1cf2295f35336367a6d587fc 100644
--- a/chrome/browser/sync/glue/non_frontend_data_type_controller.cc
+++ b/chrome/browser/sync/glue/non_frontend_data_type_controller.cc
@@ -249,18 +249,6 @@ DataTypeController::State NonFrontendDataTypeController::state() const {
return state_;
}
-void NonFrontendDataTypeController::OnUnrecoverableError(
- const tracked_objects::Location& from_here,
- const std::string& message) {
- DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
- RecordUnrecoverableError(from_here, message);
- BrowserThread::PostTask(BrowserThread::UI, from_here,
- base::Bind(&NonFrontendDataTypeController::OnUnrecoverableErrorImpl,
- this,
- from_here,
- message));
-}
-
void NonFrontendDataTypeController::OnSingleDatatypeUnrecoverableError(
const tracked_objects::Location& from_here,
const std::string& message) {
@@ -359,13 +347,6 @@ void NonFrontendDataTypeController::StopModels() {
// Do nothing by default.
}
-void NonFrontendDataTypeController::OnUnrecoverableErrorImpl(
- const tracked_objects::Location& from_here,
- const std::string& message) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- profile_sync_service_->OnUnrecoverableError(from_here, message);
-}
-
void NonFrontendDataTypeController::DisableImpl(
const tracked_objects::Location& from_here,
const std::string& message) {

Powered by Google App Engine
This is Rietveld 408576698