Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2766)

Unified Diff: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc

Issue 10553042: sync: don't make DataTypeErrorHandler inherit UnrecoverableErrorHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
index 175bbca5a1bb6e856162735689e993f6cc4ec82c..d1689748bbf229c9f04d88f7bd1270f10eefa4d2 100644
--- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
@@ -279,12 +279,12 @@ TEST_F(SyncBookmarkDataTypeControllerTest, Stop) {
EXPECT_EQ(DataTypeController::NOT_RUNNING, bookmark_dtc_->state());
}
-TEST_F(SyncBookmarkDataTypeControllerTest, OnUnrecoverableError) {
+TEST_F(SyncBookmarkDataTypeControllerTest, OnSingleDatatypeUnrecoverableError) {
SetStartExpectations();
SetAssociateExpectations();
EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(service_, OnUnrecoverableError(_,_)).
+ EXPECT_CALL(service_, OnDisableDatatype(_,_,_)).
WillOnce(InvokeWithoutArgs(bookmark_dtc_.get(),
&BookmarkDataTypeController::Stop));
SetStopExpectations();
@@ -292,6 +292,6 @@ TEST_F(SyncBookmarkDataTypeControllerTest, OnUnrecoverableError) {
EXPECT_CALL(start_callback_, Run(DataTypeController::OK, _));
Start();
// This should cause bookmark_dtc_->Stop() to be called.
- bookmark_dtc_->OnUnrecoverableError(FROM_HERE, "Test");
+ bookmark_dtc_->OnSingleDatatypeUnrecoverableError(FROM_HERE, "Test");
PumpLoop();
}

Powered by Google App Engine
This is Rietveld 408576698