Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 10535052: Make Ninja backend robust to rules and actions containing slashes (Closed)

Created:
8 years, 6 months ago by Steve Block
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Make backends robust to rules and actions containing slashes TEST=test/sanitize-rule-names/ r1411

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Make Ninja backend robust to rules and actions containing slashes #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M pylib/gyp/generator/make.py View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M pylib/gyp/generator/scons.py View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M pylib/gyp/generator/xcode.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M test/sanitize-rule-names/sanitize-rule-names.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Steve Block
8 years, 6 months ago (2012-06-07 10:09:50 UTC) #1
Nico
Can you add a test for this?
8 years, 6 months ago (2012-06-07 14:35:38 UTC) #2
Steve Block
I've updated the patch to use the approach in https://chromiumcodereview.appspot.com/10269012 and expanded an existing test
8 years, 6 months ago (2012-06-07 15:20:46 UTC) #3
Nico
xcode doesn't like / in rule names either: /usr/bin/python test/sanitize-rule-names/gyptest-sanitize-rule-names.py None returned 1 STDOUT ========================================================================= ...
8 years, 6 months ago (2012-06-07 15:32:58 UTC) #4
Steve Block
Make Ninja backend robust to rules and actions containing slashes TEST=test/sanitize-rule-names/
8 years, 6 months ago (2012-06-07 15:34:37 UTC) #5
Steve Block
Have fixed all backends - trybots now seem happy
8 years, 6 months ago (2012-06-07 16:09:23 UTC) #6
Nico
8 years, 6 months ago (2012-06-07 16:40:51 UTC) #7
lgtm

r1411, thanks!

Powered by Google App Engine
This is Rietveld 408576698