Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/sanitize-rule-names/sanitize-rule-names.gyp

Issue 10535052: Make Ninja backend robust to rules and actions containing slashes (Closed) Base URL: http://git.chromium.org/external/gyp.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/xcode.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/sanitize-rule-names/sanitize-rule-names.gyp
===================================================================
--- test/sanitize-rule-names/sanitize-rule-names.gyp (revision 1410)
+++ test/sanitize-rule-names/sanitize-rule-names.gyp (working copy)
@@ -10,7 +10,7 @@
'rules': [
{
# Make sure this rule name doesn't cause an invalid ninja file.
- 'rule_name': 'assembler (gnu-compatible)',
+ 'rule_name': 'rule name with odd characters ()/',
'extension': 'S',
'outputs': ['outfile'],
'msvs_cygwin_shell': 0,
« no previous file with comments | « pylib/gyp/generator/xcode.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698