pylib/gyp/generator/make.py - Issue 10535052: Make Ninja backend robust to rules and actions containing slashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/make.py

Issue 10535052: Make Ninja backend robust to rules and actions containing slashes (Closed) Base URL: http://git.chromium.org/external/gyp.git@master

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/make.py

===================================================================

--- pylib/gyp/generator/make.py (revision 1410)

+++ pylib/gyp/generator/make.py (working copy)

@@ -602,8 +602,7 @@

def StringToMakefileVariable(string):

"""Convert a string to a value that is acceptable as a make variable name."""

- # TODO: replace other metacharacters that we encounter.

- return re.sub('[ {}$]', '_', string)

+ return re.sub('[^a-zA-Z0-9_]', '_', string)

srcdir_prefix = ''

« no previous file with comments | « no previous file | pylib/gyp/generator/ninja.py » ('j') | no next file with comments »