pylib/gyp/generator/xcode.py - Issue 10535052: Make Ninja backend robust to rules and actions containing slashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/xcode.py

Issue 10535052: Make Ninja backend robust to rules and actions containing slashes (Closed) Base URL: http://git.chromium.org/external/gyp.git@master

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/xcode.py

===================================================================

--- pylib/gyp/generator/xcode.py (revision 1410)

+++ pylib/gyp/generator/xcode.py (working copy)

@@ -926,7 +926,8 @@

if len(concrete_outputs_all) > 0:

# TODO(mark): There's a possibilty for collision here. Consider

# target "t" rule "A_r" and target "t_A" rule "r".

- makefile_name = '%s_%s.make' % (target_name, rule['rule_name'])

+ makefile_name = '%s.make' % re.sub(

+ '[^a-zA-Z0-9_]', '_' , '%s_%s' % (target_name, rule['rule_name']))

makefile_path = os.path.join(xcode_projects[build_file].path,

makefile_name)

# TODO(mark): try/close? Write to a temporary file and swap it only

« no previous file with comments | « pylib/gyp/generator/scons.py ('k') | test/sanitize-rule-names/sanitize-rule-names.gyp » ('j') | no next file with comments »