Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive. (Closed)

Created:
8 years, 6 months ago by Mike West
Modified:
8 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Visibility:
Public.

Description

Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140018

Patch Set 1 #

Patch Set 2 : Bernhard. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -46 lines) Patch
M chrome/browser/browsing_data_appcache_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_database_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_file_system_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_helper.h View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data_helper.cc View 1 2 chunks +22 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data_helper_unittest.cc View 2 chunks +56 lines, -24 lines 0 comments Download
M chrome/browser/browsing_data_indexed_db_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data_quota_helper_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_remover.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
So, LGTY?
8 years, 6 months ago (2012-06-01 09:39:17 UTC) #1
Bernhard Bauer
lgtm
8 years, 6 months ago (2012-06-01 10:03:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/10454113/5001
8 years, 6 months ago (2012-06-01 10:03:51 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 11:55:44 UTC) #4
Change committed as 140018

Powered by Google App Engine
This is Rietveld 408576698