Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: chrome/browser/browsing_data_appcache_helper.cc

Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bernhard. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data_database_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data_appcache_helper.cc
diff --git a/chrome/browser/browsing_data_appcache_helper.cc b/chrome/browser/browsing_data_appcache_helper.cc
index d36c467ca41336231294ed54f33e1ba6a3968516..8a823cfed3e859910683376e9f49e57a1f0dab38 100644
--- a/chrome/browser/browsing_data_appcache_helper.cc
+++ b/chrome/browser/browsing_data_appcache_helper.cc
@@ -71,7 +71,7 @@ void BrowsingDataAppCacheHelper::OnFetchComplete(int rv) {
origin != origin_map.end();) {
InfoByOrigin::iterator current = origin;
++origin;
- if (!BrowsingDataHelper::HasValidScheme(current->first))
+ if (!BrowsingDataHelper::HasWebScheme(current->first))
origin_map.erase(current);
}
@@ -105,7 +105,7 @@ CannedBrowsingDataAppCacheHelper* CannedBrowsingDataAppCacheHelper::Clone() {
}
void CannedBrowsingDataAppCacheHelper::AddAppCache(const GURL& manifest_url) {
- if (!BrowsingDataHelper::HasValidScheme(manifest_url))
+ if (!BrowsingDataHelper::HasWebScheme(manifest_url))
return; // Ignore non-websafe schemes.
OriginAppCacheInfoMap& origin_map = info_collection_->infos_by_origin;
« no previous file with comments | « no previous file | chrome/browser/browsing_data_database_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698