chrome/browser/browsing_data_remover.cc - Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data_remover.cc

Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bernhard. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data_remover.cc b/chrome/browser/browsing_data_remover.cc

index 592cc8066e82dbcd7c32889d5396896f007b0f87..fb1736f08eb71bfa443d056428da3935ffbdd7fb 100644

--- a/chrome/browser/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data_remover.cc

@@ -634,7 +634,7 @@ void BrowsingDataRemover::OnGotQuotaManagedOrigins(

// isn't protected.

std::set<GURL>::const_iterator origin;

for (origin = origins.begin(); origin != origins.end(); ++origin) {

- if (!BrowsingDataHelper::IsValidScheme(origin->scheme()))

+ if (!BrowsingDataHelper::IsWebScheme(origin->scheme()))

continue;

if (special_storage_policy_->IsStorageProtected(origin->GetOrigin()))

continue;

« no previous file with comments | « chrome/browser/browsing_data_quota_helper_impl.cc ('k') | no next file » | no next file with comments »