chrome/browser/browsing_data_file_system_helper.cc - Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data_file_system_helper.cc

Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Bernhard. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browsing_data_file_system_helper.cc

diff --git a/chrome/browser/browsing_data_file_system_helper.cc b/chrome/browser/browsing_data_file_system_helper.cc

index 587dac2e89e50ebccafaf0357db23196afc377ca..5bd06f8dbc752a829dec502f30aaa070503403b9 100644

--- a/chrome/browser/browsing_data_file_system_helper.cc

+++ b/chrome/browser/browsing_data_file_system_helper.cc

@@ -127,7 +127,7 @@ void BrowsingDataFileSystemHelperImpl::FetchFileSystemInfoInFileThread() {

GURL current;

while (!(current = origin_enumerator->Next()).is_empty()) {

- if (!BrowsingDataHelper::HasValidScheme(current))

+ if (!BrowsingDataHelper::HasWebScheme(current))

continue; // Non-websafe state is not considered browsing data.

// We can call these synchronous methods as we've already verified that

@@ -241,7 +241,7 @@ void CannedBrowsingDataFileSystemHelper::AddFileSystem(

if (duplicate_origin)

return;

- if (!BrowsingDataHelper::HasValidScheme(origin))

+ if (!BrowsingDataHelper::HasWebScheme(origin))

return; // Non-websafe state is not considered browsing data.

file_system_info_.push_back(FileSystemInfo(

« no previous file with comments | « chrome/browser/browsing_data_database_helper.cc ('k') | chrome/browser/browsing_data_helper.h » ('j') | no next file with comments »