Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: chrome/browser/browsing_data_helper.h

Issue 10454113: Renaming `BrowsingDataHelper::IsValidScheme`, as it's poorly descriptive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bernhard. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data_file_system_helper.cc ('k') | chrome/browser/browsing_data_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data_helper.h
diff --git a/chrome/browser/browsing_data_helper.h b/chrome/browser/browsing_data_helper.h
index 68a3e8e9892adb7600e7acfa3d0cd165cf6fa88a..ea7a486c61d861f091522cba938848586b88fc01 100644
--- a/chrome/browser/browsing_data_helper.h
+++ b/chrome/browser/browsing_data_helper.h
@@ -24,9 +24,14 @@ class BrowsingDataHelper {
// for treatment as "browsing data". This relies on the definition of web safe
// in ChildProcessSecurityPolicy, but excluding schemes like
// `chrome-extension`.
- static bool IsValidScheme(const std::string& scheme);
- static bool IsValidScheme(const WebKit::WebString& scheme);
- static bool HasValidScheme(const GURL& origin);
+ static bool IsWebScheme(const std::string& scheme);
+ static bool IsWebScheme(const WebKit::WebString& scheme);
+ static bool HasWebScheme(const GURL& origin);
+
+ // Returns true iff the provided scheme is an extension.
+ static bool IsExtensionScheme(const std::string& scheme);
+ static bool IsExtensionScheme(const WebKit::WebString& scheme);
+ static bool HasExtensionScheme(const GURL& origin);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(BrowsingDataHelper);
« no previous file with comments | « chrome/browser/browsing_data_file_system_helper.cc ('k') | chrome/browser/browsing_data_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698