sync: Make BaseNode lookup-related Init functions return specific failures.

sync: Make BaseNode lookup-related Init functions return specific failures.

This will help glue/ code raise separate UnrecoverableErrors (e.g. for encryption issues vs
weird corruption) more easily.

BUG=121587, 123223, 123647
TEST=unit tests / sync_unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133320

[Nicolas Zea, 2012-04-19 23:55:43]

LGTM

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_autofill_unittest.cc (right):

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_autofill_unittest.cc:85: using
sync_api::BaseNode;
nit: remove this or remove BaseNode:: prefix's below

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_bookmark_unittest.cc (right):

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_bookmark_unittest.cc:46: using
sync_api::BaseNode;
same here

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_preference_unittest.cc (right):

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_preference_unittest.cc:67:
syncable::ModelTypeToRootTag(syncable::PREFERENCES)) !=
nit: move to prev line? (if it fits)

[tim (not reviewing), 2012-04-20 18:27:04]

Comments addressed and worked around weird read_node_mock issue by reverting it.
 I'll remove the file in a follow up patch, looks like it won't go down easy
with this one.

Sending to CQ! Thanks.

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_autofill_unittest.cc (right):

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_autofill_unittest.cc:85: using
sync_api::BaseNode;
On 2012/04/19 23:55:43, nzea wrote:
> nit: remove this or remove BaseNode:: prefix's below

As discussed offline, using decl only lets us drop the namespace::.

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service_preference_unittest.cc (right):

http://codereview.chromium.org/10152003/diff/2001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service_preference_unittest.cc:67:
syncable::ModelTypeToRootTag(syncable::PREFERENCES)) !=
On 2012/04/19 23:55:43, nzea wrote:
> nit: move to prev line? (if it fits)

Done.

[commit-bot: I haz the power, 2012-04-20 18:28:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/10152003/14002

[commit-bot: I haz the power, 2012-04-20 20:38:10]

Can't apply patch for file
chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc.
While running patch -p1 --forward --force;
patching file
chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc.rej

[commit-bot: I haz the power, 2012-04-20 21:19:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/10152003/14033

[commit-bot: I haz the power, 2012-04-20 22:47:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/10152003/14033

[commit-bot: I haz the power, 2012-04-21 01:28:17]

Change committed as 133320