chrome/browser/sync/profile_sync_service_session_unittest.cc - Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_session_unittest.cc

Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_preference_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_session_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_session_unittest.cc b/chrome/browser/sync/profile_sync_service_session_unittest.cc

index 0b860fc702d0675c6fcf273c724c57b7952528b9..2a32d8d57f3fe2bd8c29499fab294ed75bc13d8b 100644

--- a/chrome/browser/sync/profile_sync_service_session_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_session_unittest.cc

@@ -315,7 +315,8 @@ TEST_F(ProfileSyncServiceSessionTest, WriteSessionToNode) {

// Check that we can get the correct session specifics back from the node.

sync_api::ReadTransaction trans(FROM_HERE, sync_service_->GetUserShare());

sync_api::ReadNode node(&trans);

- ASSERT_TRUE(node.InitByClientTagLookup(syncable::SESSIONS, machine_tag));

+ ASSERT_EQ(sync_api::BaseNode::INIT_OK,

+ node.InitByClientTagLookup(syncable::SESSIONS, machine_tag));

const sync_pb::SessionSpecifics& specifics(node.GetSessionSpecifics());

ASSERT_EQ(machine_tag, specifics.session_tag());

ASSERT_TRUE(specifics.has_header());