chrome/browser/sync/internal_api/change_reorder_buffer.cc - Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/internal_api/change_reorder_buffer.cc

Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/internal_api/change_reorder_buffer.cc

diff --git a/chrome/browser/sync/internal_api/change_reorder_buffer.cc b/chrome/browser/sync/internal_api/change_reorder_buffer.cc

index 04c0955899ad475d42e51a3c82251bef2d124015..f262ff64e05662b68a327c6fa979dcc786f70f56 100644

--- a/chrome/browser/sync/internal_api/change_reorder_buffer.cc

+++ b/chrome/browser/sync/internal_api/change_reorder_buffer.cc

@@ -151,7 +151,7 @@ bool ChangeReorderBuffer::GetAllChangesInTreeOrder(

if (i->second == OP_ADD ||

i->second == OP_UPDATE_POSITION_AND_PROPERTIES) {

ReadNode node(sync_trans);

- CHECK(node.InitByIdLookup(i->first));

+ CHECK_EQ(BaseNode::INIT_OK, node.InitByIdLookup(i->first));

// We only care about parents of entry's with position-sensitive models.

if (syncable::ShouldMaintainPosition(

« no previous file with comments | « chrome/browser/sync/internal_api/base_node.h ('k') | chrome/browser/sync/internal_api/read_node.h » ('j') | no next file with comments »