chrome/browser/sync/profile_sync_service_password_unittest.cc - Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_password_unittest.cc

Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_bookmark_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_preference_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_password_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_password_unittest.cc b/chrome/browser/sync/profile_sync_service_password_unittest.cc

index b90e6448073b9d2b7074a69cd3c6cf7475511e39..55771848ae94228fcbc23f707d34bdd160bed20f 100644

--- a/chrome/browser/sync/profile_sync_service_password_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_password_unittest.cc

@@ -141,7 +141,8 @@ class ProfileSyncServicePasswordTest : public AbstractProfileSyncServiceTest {

void AddPasswordSyncNode(const PasswordForm& entry) {

sync_api::WriteTransaction trans(FROM_HERE, service_->GetUserShare());

sync_api::ReadNode password_root(&trans);

- ASSERT_TRUE(password_root.InitByTagLookup(browser_sync::kPasswordTag));

+ ASSERT_EQ(sync_api::BaseNode::INIT_OK,

+ password_root.InitByTagLookup(browser_sync::kPasswordTag));

sync_api::WriteNode node(&trans);

std::string tag = PasswordModelAssociator::MakeTag(entry);

@@ -245,12 +246,14 @@ class ProfileSyncServicePasswordTest : public AbstractProfileSyncServiceTest {

void GetPasswordEntriesFromSyncDB(std::vector<PasswordForm>* entries) {

sync_api::ReadTransaction trans(FROM_HERE, service_->GetUserShare());

sync_api::ReadNode password_root(&trans);

- ASSERT_TRUE(password_root.InitByTagLookup(browser_sync::kPasswordTag));

+ ASSERT_EQ(sync_api::BaseNode::INIT_OK,

+ password_root.InitByTagLookup(browser_sync::kPasswordTag));

int64 child_id = password_root.GetFirstChildId();

while (child_id != sync_api::kInvalidId) {

sync_api::ReadNode child_node(&trans);

- ASSERT_TRUE(child_node.InitByIdLookup(child_id));

+ ASSERT_EQ(sync_api::BaseNode::INIT_OK,

+ child_node.InitByIdLookup(child_id));

const sync_pb::PasswordSpecificsData& password =

child_node.GetPasswordSpecifics();