chrome/browser/sync/glue/bookmark_model_associator.h - Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_model_associator.h

Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.cc ('k') | chrome/browser/sync/glue/bookmark_model_associator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/bookmark_model_associator.h

diff --git a/chrome/browser/sync/glue/bookmark_model_associator.h b/chrome/browser/sync/glue/bookmark_model_associator.h

index d2828c7af313db064b53a4e389cca3a7352a4e4e..31ade9e95df06a91d57bc1aefa2744bc87ad2911 100644

--- a/chrome/browser/sync/glue/bookmark_model_associator.h

+++ b/chrome/browser/sync/glue/bookmark_model_associator.h

@@ -78,8 +78,9 @@ class BookmarkModelAssociator

// Initializes the given sync node from the given bookmark node id.

// Returns false if no sync node was found for the given bookmark node id or

// if the initialization of sync node fails.

- virtual bool InitSyncNodeFromChromeId(const int64& node_id,

- sync_api::BaseNode* sync_node) OVERRIDE;

+ virtual bool InitSyncNodeFromChromeId(

+ const int64& node_id,

+ sync_api::BaseNode* sync_node) OVERRIDE;

// Associates the given bookmark node with the given sync id.

virtual void Associate(const BookmarkNode* node, int64 sync_id) OVERRIDE;

« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.cc ('k') | chrome/browser/sync/glue/bookmark_model_associator.cc » ('j') | no next file with comments »