Issue 8632010: double-conversion drop.

Issue 8632010: double-conversion drop. (Closed)

Created:
9 years, 1 month ago by floitsch

Modified:
9 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

double-conversion drop. Not yet integrated into build process. Committed: https://code.google.com/p/dart/source/detail?r=1870

Patch Set 2 : Updated to latest double-conversion version. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5726 lines, -0 lines)			Patch
A	runtime/third_party/double-conversion/AUTHORS	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/COPYING	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/LICENSE	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/README	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/README.dart	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/bignum.h	View	1	1 chunk	+141 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/bignum.cc	View	1	1 chunk	+764 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/bignum-dtoa.h	View	1	1 chunk	+82 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/bignum-dtoa.cc	View	1	1 chunk	+653 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/cached-powers.h	View	1	1 chunk	+64 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/cached-powers.cc	View	1	1 chunk	+175 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/diy-fp.h	View	1	1 chunk	+118 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/diy-fp.cc	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/double.h	View	1	1 chunk	+245 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/double-conversion.h	View	1	1 chunk	+498 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/double-conversion.cc	View	1	1 chunk	+869 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/fast-dtoa.h	View	1	1 chunk	+84 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/fast-dtoa.cc	View	1	1 chunk	+656 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/fixed-dtoa.h	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/fixed-dtoa.cc	View	1	1 chunk	+402 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/strtod.h	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/strtod.cc	View	1	1 chunk	+441 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/utils.h	View	1	1 chunk	+297 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

On 2011/11/22 14:18:54, floitsch wrote: > I will delete the test directory in the next ...

9 years, 1 month ago (2011-11-23 23:18:18 UTC) #3

Ivan Posva

http://codereview.chromium.org/8632010/diff/1/runtime/third_party/double-conversion/SConstruct File runtime/third_party/double-conversion/SConstruct (right): http://codereview.chromium.org/8632010/diff/1/runtime/third_party/double-conversion/SConstruct#newcode1 runtime/third_party/double-conversion/SConstruct:1: double_conversion_sources = ['src/' + x for x in SConscript('src/SConscript')] ...

9 years, 1 month ago (2011-11-23 23:19:19 UTC) #4

floitsch

Updated to latest double-conversion version. Removed test-directory and scons files.

9 years ago (2011-11-28 18:02:25 UTC) #5

LGTM -ip

Expand Messages | Collapse Messages