Issue 8549033: Update comments in core lib showing proper factory syntax.

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed)

Created:
9 years, 1 month ago by regis

Modified:
9 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update comments in core lib showing proper factory syntax. Improve error messages reported from class finalizer. Fix parser error reporting to be thread safe. Reformat type error and failed assertion messages to be consistent. Add one more new factory syntax test. Committed: https://code.google.com/p/dart/source/detail?r=1708

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+286 lines, -147 lines)			Patch
M	corelib/src/implementation/hash_map_set.dart	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	corelib/src/implementation/linked_hash_map.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	corelib/src/implementation/queue.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	corelib/src/map.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	corelib/src/set.dart	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/lib/error.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/lib/error.dart	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	runtime/vm/class_finalizer.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View		23 chunks	+94 lines, -70 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	runtime/vm/parser.h	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/vm/parser.cc	View		1 chunk	+81 lines, -28 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/Factory3Test.dart	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

Nice mixed bag of changes :) LGTM. http://codereview.chromium.org/8549033/diff/1/tests/language/src/Factory3Test.dart File tests/language/src/Factory3Test.dart (right): http://codereview.chromium.org/8549033/diff/1/tests/language/src/Factory3Test.dart#newcode12 tests/language/src/Factory3Test.dart:12: const EmptyLink(); ...

9 years, 1 month ago (2011-11-19 00:04:43 UTC) #2

regis

9 years, 1 month ago (2011-11-19 00:21:18 UTC) #3

Thanks!

http://codereview.chromium.org/8549033/diff/1/tests/language/src/Factory3Test...
File tests/language/src/Factory3Test.dart (right):

http://codereview.chromium.org/8549033/diff/1/tests/language/src/Factory3Test...
tests/language/src/Factory3Test.dart:12: const EmptyLink();
On 2011/11/19 00:04:44, hausner wrote:
> Need to mark this test as failing for dartc and frog?

Marked as failing for frog, but it is passing for dartc.

Expand Messages | Collapse Messages