Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 1677)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -2744,13 +2744,17 @@
void CodeGenerator::ErrorMsg(intptr_t token_index, const char* format, ...) {
- char error_msg[Parser::kErrorBuflen];
+ const intptr_t kMessageBufferSize = 512;
+ char message_buffer[kMessageBufferSize];
va_list args;
va_start(args, format);
const Class& cls = Class::Handle(parsed_function_.function().owner());
const Script& script = Script::Handle(cls.script());
- Parser::ReportMsg(script, token_index, "Error", error_msg, format, args);
- Isolate::Current()->long_jump_base()->Jump(1, error_msg);
+ Parser::FormatMessage(script, token_index, "Error",
+ message_buffer, kMessageBufferSize,
+ format, args);
+ va_end(args);
+ Isolate::Current()->long_jump_base()->Jump(1, message_buffer);
UNREACHABLE();
}
« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698