Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: runtime/vm/parser.h

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.h
===================================================================
--- runtime/vm/parser.h (revision 1677)
+++ runtime/vm/parser.h (working copy)
@@ -68,8 +68,6 @@
class Parser : ValueObject {
public:
- static const int kErrorBuflen = 512;
-
Parser(const Script& script, const Library& library);
Parser(const Script& script,
const Function& function,
@@ -82,11 +80,15 @@
static void ParseFunction(ParsedFunction* parsed_function);
- static void ReportMsg(const Script& script,
- intptr_t token_index,
- const char* msg_type,
- char* message,
- const char* format, va_list args);
+ // Format an error or warning message into the message_buffer.
+ // A null script means no source and a negative token_index means no position.
+ static void FormatMessage(const Script& script,
+ intptr_t token_index,
+ const char* message_header,
+ char* message_buffer,
+ intptr_t message_buffer_size,
+ const char* format,
+ va_list args);
private:
struct Block;
@@ -442,8 +444,6 @@
// done using 'return', 'break' or 'continue' statements.
TryBlocks* try_blocks_list_;
- char error_msg_[kErrorBuflen];
-
DISALLOW_COPY_AND_ASSIGN(Parser);
};
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698