Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: corelib/src/implementation/hash_map_set.dart

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | corelib/src/implementation/linked_hash_map.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/hash_map_set.dart
===================================================================
--- corelib/src/implementation/hash_map_set.dart (revision 1677)
+++ corelib/src/implementation/hash_map_set.dart (working copy)
@@ -50,10 +50,10 @@
_values = new List<V>(_INITIAL_CAPACITY);
}
- // See bug 5257789. Works in the vm, fails in dartc and frog.
- factory HashMapImplementation/* <K, V> */.from(Map/* <K, V> */other) {
- Map/* <K, V> */ result = new HashMapImplementation/* <K, V> */();
- other.forEach((/* K */ key, /* V */ value) { result[key] = value; });
+ // See issue 417. Works in the vm, fails in dartc and frog.
+ factory HashMapImplementation/*<K, V>*/.from(Map/*<K, V>*/ other) {
+ Map/*<K, V>*/ result = new HashMapImplementation/*<K, V>*/();
+ other.forEach((/*K*/ key, /*V*/ value) { result[key] = value; });
return result;
}
@@ -275,9 +275,9 @@
_backingMap = new HashMapImplementation<E, E>();
}
- // See bug 5257789.
- factory HashSetImplementation/* <E> */.from(Iterable/* <E> */ other) {
- Set/* <E> */ set = new HashSetImplementation/* <E> */();
+ // See issue 417. Works in the vm, fails in dartc and frog.
+ factory HashSetImplementation/*<E>*/.from(Iterable/*<E>*/ other) {
+ Set/*<E>*/ set = new HashSetImplementation/*<E>*/();
for (final e in other) {
set.add(e);
}
« no previous file with comments | « no previous file | corelib/src/implementation/linked_hash_map.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698