Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: corelib/src/implementation/linked_hash_map.dart

Issue 8549033: Update comments in core lib showing proper factory syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « corelib/src/implementation/hash_map_set.dart ('k') | corelib/src/implementation/queue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/linked_hash_map.dart
===================================================================
--- corelib/src/implementation/linked_hash_map.dart (revision 1677)
+++ corelib/src/implementation/linked_hash_map.dart (working copy)
@@ -28,10 +28,11 @@
_list = new DoubleLinkedQueue<KeyValuePair<K, V>>();
}
- // See bug 5257789.
- factory LinkedHashMapImplementation/* <K, V> */.from(Map/* <K, V> */other) {
- Map/* <K, V> */ result = new LinkedHashMapImplementation/* <K, V> */();
- other.forEach((/* K */ key, /* V */ value) { result[key] = value; });
+ // See issue 417. Works in the vm, fails in dartc and frog.
+ factory LinkedHashMapImplementation/*<K extends Hashable, V>*/
+ .from(Map/*<K, V>*/ other) {
+ Map/*<K, V>*/ result = new LinkedHashMapImplementation/*<K, V>*/();
+ other.forEach((/*K*/ key, /*V*/ value) { result[key] = value; });
return result;
}
« no previous file with comments | « corelib/src/implementation/hash_map_set.dart ('k') | corelib/src/implementation/queue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698