Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 996133002: correctly invalidate global cells (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

correctly invalidate global cells additionally, remove unnecessary deopts when transitioning to global accessor properties from data properties R=verwaest@chromium.org BUG= Committed: https://crrev.com/d3fb7bf809227a8f9bbf86c4e6049195b8102379 Cr-Commit-Position: refs/heads/master@{#27239}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Patch Set 20 : #

Patch Set 21 : weak cell check #

Total comments: 1

Patch Set 22 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -250 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -3 lines 0 comments Download
M src/factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -12 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +0 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +6 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +5 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +13 lines, -9 lines 0 comments Download
M src/lookup.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download
M src/lookup.cc View 1 2 3 4 5 6 7 8 9 10 11 18 3 chunks +8 lines, -11 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +11 lines, -23 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 19 chunks +164 lines, -141 lines 0 comments Download
M src/objects-debug.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -9 lines 0 comments Download
M src/property-details.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +40 lines, -9 lines 0 comments Download
M src/runtime/runtime.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download
M src/transitions.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Toon Verwaest
lgtm https://codereview.chromium.org/996133002/diff/390001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/996133002/diff/390001/src/hydrogen.cc#newcode5353 src/hydrogen.cc:5353: Handle<Object> constant_object = handle(cell->value(), isolate()); Handle<Object> constant_object(cell->value(), isolate());
5 years, 9 months ago (2015-03-17 11:04:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996133002/410001
5 years, 9 months ago (2015-03-17 13:05:05 UTC) #6
commit-bot: I haz the power
Committed patchset #22 (id:410001)
5 years, 9 months ago (2015-03-17 13:27:31 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 13:27:53 UTC) #8
Message was sent while issue was closed.
Patchset 22 (id:??) landed as
https://crrev.com/d3fb7bf809227a8f9bbf86c4e6049195b8102379
Cr-Commit-Position: refs/heads/master@{#27239}

Powered by Google App Engine
This is Rietveld 408576698