Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: src/bootstrapper.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/extensions/externalize-string-extension.h" 10 #include "src/extensions/externalize-string-extension.h"
(...skipping 2685 matching lines...) Expand 10 before | Expand all | Expand 10 after
2696 case ACCESSOR_CONSTANT: { 2696 case ACCESSOR_CONSTANT: {
2697 Handle<Name> key(descs->GetKey(i)); 2697 Handle<Name> key(descs->GetKey(i));
2698 LookupIterator it(to, key, LookupIterator::OWN_SKIP_INTERCEPTOR); 2698 LookupIterator it(to, key, LookupIterator::OWN_SKIP_INTERCEPTOR);
2699 CHECK_NE(LookupIterator::ACCESS_CHECK, it.state()); 2699 CHECK_NE(LookupIterator::ACCESS_CHECK, it.state());
2700 // If the property is already there we skip it 2700 // If the property is already there we skip it
2701 if (it.IsFound()) continue; 2701 if (it.IsFound()) continue;
2702 HandleScope inner(isolate()); 2702 HandleScope inner(isolate());
2703 DCHECK(!to->HasFastProperties()); 2703 DCHECK(!to->HasFastProperties());
2704 // Add to dictionary. 2704 // Add to dictionary.
2705 Handle<Object> callbacks(descs->GetCallbacksObject(i), isolate()); 2705 Handle<Object> callbacks(descs->GetCallbacksObject(i), isolate());
2706 PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT, i + 1); 2706 PropertyDetails d(details.attributes(), ACCESSOR_CONSTANT, i + 1,
2707 PropertyCellType::kMutable);
2707 JSObject::SetNormalizedProperty(to, key, callbacks, d); 2708 JSObject::SetNormalizedProperty(to, key, callbacks, d);
2708 break; 2709 break;
2709 } 2710 }
2710 } 2711 }
2711 } 2712 }
2712 } else { 2713 } else {
2713 Handle<NameDictionary> properties = 2714 Handle<NameDictionary> properties =
2714 Handle<NameDictionary>(from->property_dictionary()); 2715 Handle<NameDictionary>(from->property_dictionary());
2715 int capacity = properties->Capacity(); 2716 int capacity = properties->Capacity();
2716 for (int i = 0; i < capacity; i++) { 2717 for (int i = 0; i < capacity; i++) {
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
2919 return from + sizeof(NestingCounterType); 2920 return from + sizeof(NestingCounterType);
2920 } 2921 }
2921 2922
2922 2923
2923 // Called when the top-level V8 mutex is destroyed. 2924 // Called when the top-level V8 mutex is destroyed.
2924 void Bootstrapper::FreeThreadResources() { 2925 void Bootstrapper::FreeThreadResources() {
2925 DCHECK(!IsActive()); 2926 DCHECK(!IsActive());
2926 } 2927 }
2927 2928
2928 } } // namespace v8::internal 2929 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698