Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: src/hydrogen-instructions.h

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index 459024efada19164027bdfd37d8ff8875371901b..0ec6887f3b4ce568e4a9541ed696fee63bdf1c73 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -5420,7 +5420,8 @@ class HLoadGlobalCell FINAL : public HTemplateInstruction<0> {
PropertyDetails);
Unique<Cell> cell() const { return cell_; }
- bool RequiresHoleCheck() const;
+ // TODO(dcarney): remove this.
+ bool RequiresHoleCheck() const { return false; }
std::ostream& PrintDataTo(std::ostream& os) const OVERRIDE; // NOLINT
@@ -5447,7 +5448,7 @@ class HLoadGlobalCell FINAL : public HTemplateInstruction<0> {
SetDependsOnFlag(kGlobalVars);
}
- bool IsDeletable() const OVERRIDE { return !RequiresHoleCheck(); }
+ bool IsDeletable() const OVERRIDE { return true; }
Unique<Cell> cell_;
PropertyDetails details_;
@@ -5811,7 +5812,8 @@ class HStoreGlobalCell FINAL : public HUnaryOperation {
Handle<PropertyCell>, PropertyDetails);
Unique<PropertyCell> cell() const { return cell_; }
- bool RequiresHoleCheck() { return details_.IsConfigurable(); }
+ // TODO(dcarney): remove
+ bool RequiresHoleCheck() const { return false; }
bool NeedsWriteBarrier() {
return StoringValueNeedsWriteBarrier(value());
}
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698