Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/factory.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/heap-snapshot-generator-inl.h" 7 #include "src/heap-snapshot-generator-inl.h"
8 8
9 #include "src/allocation-tracker.h" 9 #include "src/allocation-tracker.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1495 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 1506
1507 1507
1508 void V8HeapExplorer::ExtractCellReferences(int entry, Cell* cell) { 1508 void V8HeapExplorer::ExtractCellReferences(int entry, Cell* cell) {
1509 SetInternalReference(cell, entry, "value", cell->value(), Cell::kValueOffset); 1509 SetInternalReference(cell, entry, "value", cell->value(), Cell::kValueOffset);
1510 } 1510 }
1511 1511
1512 1512
1513 void V8HeapExplorer::ExtractPropertyCellReferences(int entry, 1513 void V8HeapExplorer::ExtractPropertyCellReferences(int entry,
1514 PropertyCell* cell) { 1514 PropertyCell* cell) {
1515 ExtractCellReferences(entry, cell); 1515 ExtractCellReferences(entry, cell);
1516 SetInternalReference(cell, entry, "type", cell->type(),
1517 PropertyCell::kTypeOffset);
1518 MarkAsWeakContainer(cell->dependent_code()); 1516 MarkAsWeakContainer(cell->dependent_code());
1519 SetInternalReference(cell, entry, "dependent_code", cell->dependent_code(), 1517 SetInternalReference(cell, entry, "dependent_code", cell->dependent_code(),
1520 PropertyCell::kDependentCodeOffset); 1518 PropertyCell::kDependentCodeOffset);
1521 } 1519 }
1522 1520
1523 1521
1524 void V8HeapExplorer::ExtractAllocationSiteReferences(int entry, 1522 void V8HeapExplorer::ExtractAllocationSiteReferences(int entry,
1525 AllocationSite* site) { 1523 AllocationSite* site) {
1526 SetInternalReference(site, entry, "transition_info", site->transition_info(), 1524 SetInternalReference(site, entry, "transition_info", site->transition_info(),
1527 AllocationSite::kTransitionInfoOffset); 1525 AllocationSite::kTransitionInfoOffset);
(...skipping 1592 matching lines...) Expand 10 before | Expand all | Expand 10 after
3120 writer_->AddString("\"<dummy>\""); 3118 writer_->AddString("\"<dummy>\"");
3121 for (int i = 1; i < sorted_strings.length(); ++i) { 3119 for (int i = 1; i < sorted_strings.length(); ++i) {
3122 writer_->AddCharacter(','); 3120 writer_->AddCharacter(',');
3123 SerializeString(sorted_strings[i]); 3121 SerializeString(sorted_strings[i]);
3124 if (writer_->aborted()) return; 3122 if (writer_->aborted()) return;
3125 } 3123 }
3126 } 3124 }
3127 3125
3128 3126
3129 } } // namespace v8::internal 3127 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/factory.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698