Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 995013005: Simplify pending message script handling. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify pending message script handling. This removes the separate tracking of the pending message script, because that script is already stored in the message object and duplicating it in the ThreadLocalTop makes it more brittle. R=bmeurer@chromium.org Committed: https://crrev.com/f71e26268338d2840133264329bf35a63011bb5a Cr-Commit-Position: refs/heads/master@{#27127}

Patch Set 1 #

Patch Set 2 : Fix hardcoded constant. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -92 lines) Patch
M include/v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/isolate.h View 3 chunks +0 lines, -7 lines 0 comments Download
M src/isolate.cc View 9 chunks +8 lines, -22 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-10 15:56:49 UTC) #1
Benedikt Meurer
Nice. LGTM
5 years, 9 months ago (2015-03-11 09:42:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995013005/20001
5 years, 9 months ago (2015-03-11 09:53:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 10:02:47 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 10:02:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f71e26268338d2840133264329bf35a63011bb5a
Cr-Commit-Position: refs/heads/master@{#27127}

Powered by Google App Engine
This is Rietveld 408576698