Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 995013005: Simplify pending message script handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix hardcoded constant. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5308 matching lines...) Expand 10 before | Expand all | Expand 10 after
5319 __ ldr(r1, MemOperand(ip)); 5319 __ ldr(r1, MemOperand(ip));
5320 __ push(r1); 5320 __ push(r1);
5321 5321
5322 ExternalReference has_pending_message = 5322 ExternalReference has_pending_message =
5323 ExternalReference::address_of_has_pending_message(isolate()); 5323 ExternalReference::address_of_has_pending_message(isolate());
5324 __ mov(ip, Operand(has_pending_message)); 5324 __ mov(ip, Operand(has_pending_message));
5325 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof) 5325 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
5326 __ ldrb(r1, MemOperand(ip)); 5326 __ ldrb(r1, MemOperand(ip));
5327 __ SmiTag(r1); 5327 __ SmiTag(r1);
5328 __ push(r1); 5328 __ push(r1);
5329
5330 ExternalReference pending_message_script =
5331 ExternalReference::address_of_pending_message_script(isolate());
5332 __ mov(ip, Operand(pending_message_script));
5333 __ ldr(r1, MemOperand(ip));
5334 __ push(r1);
5335 } 5329 }
5336 5330
5337 5331
5338 void FullCodeGenerator::ExitFinallyBlock() { 5332 void FullCodeGenerator::ExitFinallyBlock() {
5339 DCHECK(!result_register().is(r1)); 5333 DCHECK(!result_register().is(r1));
5340 // Restore pending message from stack. 5334 // Restore pending message from stack.
5341 __ pop(r1); 5335 __ pop(r1);
5342 ExternalReference pending_message_script =
5343 ExternalReference::address_of_pending_message_script(isolate());
5344 __ mov(ip, Operand(pending_message_script));
5345 __ str(r1, MemOperand(ip));
5346
5347 __ pop(r1);
5348 __ SmiUntag(r1); 5336 __ SmiUntag(r1);
5349 ExternalReference has_pending_message = 5337 ExternalReference has_pending_message =
5350 ExternalReference::address_of_has_pending_message(isolate()); 5338 ExternalReference::address_of_has_pending_message(isolate());
5351 __ mov(ip, Operand(has_pending_message)); 5339 __ mov(ip, Operand(has_pending_message));
5352 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof) 5340 STATIC_ASSERT(sizeof(bool) == 1); // NOLINT(runtime/sizeof)
5353 __ strb(r1, MemOperand(ip)); 5341 __ strb(r1, MemOperand(ip));
5354 5342
5355 __ pop(r1); 5343 __ pop(r1);
5356 ExternalReference pending_message_obj = 5344 ExternalReference pending_message_obj =
5357 ExternalReference::address_of_pending_message_obj(isolate()); 5345 ExternalReference::address_of_pending_message_obj(isolate());
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
5534 5522
5535 DCHECK(interrupt_address == 5523 DCHECK(interrupt_address ==
5536 isolate->builtins()->OsrAfterStackCheck()->entry()); 5524 isolate->builtins()->OsrAfterStackCheck()->entry());
5537 return OSR_AFTER_STACK_CHECK; 5525 return OSR_AFTER_STACK_CHECK;
5538 } 5526 }
5539 5527
5540 5528
5541 } } // namespace v8::internal 5529 } } // namespace v8::internal
5542 5530
5543 #endif // V8_TARGET_ARCH_ARM 5531 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698